Refs #525 html5 multiple file input support #1425
Conversation
|
Hi, thank you for your contribution. Would you mind to squash your commits into one with a meaningful label - like "added support for multiple file input" for instance ? Mickaël |
|
Squashed as requested. I hope it is right as I am doing this for the first time. Regards, |
|
Not realy :D, try this:
git rebase -i 40213c2c // your very first commit
git commit --allow-empty && git push -f origin refs-525-HTML5-multiple-file-input-supportMickaël |
albuquerque
force-pushed
the
refs-525-HTML5-multiple-file-input-support
branch
from
e21b167
to
6571e66
Compare
|
HI @mickaelandrieu, Followed your instructions. I had to use git commit --amend --allow-empty as it was throwing an "Aborting commit due to empty commit message" error. However, it's now showing three additional files that are not part of my changes.
|
|
Yes, because your repository is not synced with n1k0's one. Mickaël |
albuquerque
force-pushed
the
refs-525-HTML5-multiple-file-input-support
branch
from
6571e66
to
afd46fc
Compare
Added support for multiple file uploads fixed scope of fileFieldSelector fixed scope of fileFieldSelector changed the check for file.path to check if length > 0 instead of 1 When file.path.length was 1 and file.path was an array(when uploading single file to a multiple input) the path would be set as a nested array. The updated behaviour will to do this only if the file.path.length is 0. This should throw a non-existent file error during paths.map Reverted the matchEngine change Skip the "file multiple" test on phantomjs 2.0.0 Test fails on phantomjs 2.0.0 due to a fakepath issue Add tests for command line options Specifically to catch options incorrectly sent to the engine instead of the script. See #1384. Fix assignment of options to engine vs script Consider entire option name, not just initial chars. Fixes #1384. fixed scope of fileFieldSelector Reverted the matchEngine change Skip the "file multiple" test on phantomjs 2.0.0 Test fails on phantomjs 2.0.0 due to a fakepath issue Add tests for command line options Specifically to catch options incorrectly sent to the engine instead of the script. See #1384. Fix assignment of options to engine vs script Consider entire option name, not just initial chars. Fixes #1384.
albuquerque
force-pushed
the
refs-525-HTML5-multiple-file-input-support
branch
from
afd46fc
to
c9066f3
Compare
|
damn, tests are now broken :/ I don't realy know why to be honest /c @istr |
That is an intermittent error (popup problem #1354), we'll hopefully have fixed very soon (root cause found by @jefleponot). |
|
Thanks for clearing that up @istr. |
|
@istr implementation sounds good to me. 👍 |
|
@mickaelandrieu Seems complete, 👍 to merge. Could you please check if the PhantomJS 2.0.0 specific form regression ariya/phantomjs#12506 is documented somewhere in CasperJS? |
|
@istr for sure it's not documented even in Casper or in phantomJS docs :) |
|
Ok. Opened a new issue for engine quirks documentation. Merging this one. |
Added support to upload multiple files at once.
New test added to test the feature.
Code is refactoring and cleanup of pending pull request refs #526 which seems to have been abandoned by the original author.