This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
Prevent overriding of preconfigured casper instance in a test environment #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a hard decision to take, but too many people just don't read the docs and create new casper instance in a test env, overriding the preconfigured one which creates cumbersome and hard to understand situation. Hopefully this change will inform users right from the place they read docs the most, fatal error messages.
n1k0
added a commit
that referenced
this pull request
Nov 27, 2013
…-test-env Prevent overriding of preconfigured casper instance in a test environment
n1k0
added a commit
that referenced
this pull request
Nov 27, 2013
|
👍 |
|
It's worth mentioning the error message |
|
@icoloma sure, will add it to the description as well |
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a hard decision to make, but too many people just don't read the docs and create new casper instance(s) in a test env, overriding the preconfigured one, therefore creating cumbersome, hard to understand situations.
Hopefully this change will inform users right from the place they read docs the most, fatal error messages. So as of now you'll get this fatal error when creating a new casper instance in your test script:
Reminder: when using the
casperjs testsubcommand, you must not create a newcasperinstance, just use the provided one. You may argue it's always been a bad design decision, but that's the way it is. We'll change this for 2.0.