-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port extension to Gnome version 46 #15
base: master
Are you sure you want to change the base?
Conversation
Seems like I missed the pull requests. I have not tested this but the code changes look good to me. Good work I'll merge it tomorrow into master and create a gnome 45 branch for the older version. Stay tuned. |
I had a closer look now. Tested your version with qemu.
This issues should be addressed, before merging this into master. |
@cass00 Thanks for the review, I will have a look at these points in the next few days.... |
The panel indicator should be hidden when the "Screen Keyboard" accessibility feature is off, as it'd then do nothing and serve no purpose. EDIT: Actually I have noticed the current behaviour causes the enabling - disabling - enabling cycle to not work properly:
|
}) | ||
|
||
this._injectionManager.overrideMethod( | ||
Keyboard.Keyboard.prototype, '_toggleDelete', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't delete this section! This bug has not been fixed in GNOME. db77e7e
Sorry for the inactivity on this, I've been out the past few weeks with health issues. I'll try to have a look in the upcoming days but no guarantees as I'm still recovering 🤕 |
Addresses #14
ui/keyboard.js
As this is a breaking change to the extension and will only work on Gnome 46 I'm not sure how you want to proceed. Should there be a separate release branch for this new version or how do you usually handle backwards compatibility?