Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port extension to Gnome version 46 #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brunnseb
Copy link

Addresses #14

  • Updated all osk layouts to use strings for levels instead of numbers
  • Updated code wherever needed to address internal API changes to ui/keyboard.js
  • Removed logic for caps_lock on long press shift as this is now default behavior in Gnome 46

As this is a breaking change to the extension and will only work on Gnome 46 I'm not sure how you want to proceed. Should there be a separate release branch for this new version or how do you usually handle backwards compatibility?

@cass00
Copy link
Owner

cass00 commented May 20, 2024

Seems like I missed the pull requests. I have not tested this but the code changes look good to me. Good work I'll merge it tomorrow into master and create a gnome 45 branch for the older version. Stay tuned.

@cass00
Copy link
Owner

cass00 commented May 21, 2024

I had a closer look now. Tested your version with qemu.

  • The caps lock logic was added for a reason. See commit a8a48fe and 28d23ad. In the current state caps lock on long press does not work for me, most likely because of the changes in json file in commit a8a48fe .

  • Another problem is that modifiers are disabled on level change. Therefore key combinations like Alt-F2 won't work. I think you added this._disableAllModifiers(); in _setActiveLevel which causes this problem.

This issues should be addressed, before merging this into master.

@brunnseb
Copy link
Author

@cass00 Thanks for the review, I will have a look at these points in the next few days....

@teohhanhui
Copy link

teohhanhui commented May 27, 2024

The panel indicator should be hidden when the "Screen Keyboard" accessibility feature is off, as it'd then do nothing and serve no purpose.

EDIT: Actually I have noticed the current behaviour causes the enabling - disabling - enabling cycle to not work properly:

Error: Extension point conflict: there is already a status indicator for role OSKIndicator

})

this._injectionManager.overrideMethod(
Keyboard.Keyboard.prototype, '_toggleDelete',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't delete this section! This bug has not been fixed in GNOME. db77e7e

@brunnseb
Copy link
Author

Sorry for the inactivity on this, I've been out the past few weeks with health issues. I'll try to have a look in the upcoming days but no guarantees as I'm still recovering 🤕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants