#34 Support Update Statement #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabdulradi
requested changes
Oct 9, 2016
| @@ -68,4 +69,18 @@ class UpdateStatementParserTest extends FlatSpec with Matchers { | |||
| simpleRelation2.term.asInstanceOf[Constant].raw shouldBe "click" | |||
|
|
|||
| } | |||
|
|
|||
| it should "parse update statement with list literal assignment" in { | |||
There was a problem hiding this comment.
Please add more test cases for the parser. Also, test for BindMarkers in different places of the statement.
| @@ -32,6 +32,12 @@ object Messages { | |||
| // Validations | |||
| case class SelectedDistinctNonStaticColumn(c: Identifier) extends Message(s"SELECT DISTINCT queries must only request partition key columns and/or static columns (not $c)") | |||
|
|
|||
| // TODO: Format Term | |||
There was a problem hiding this comment.
Please move those new classes to line 26.
| schema.getTable(s.tableName).flatMap { table => | ||
| V.merge(Seq( | ||
| extractVariablesFomSet(table, s.set), | ||
| extractVariablesFromUpdateParam(table, s.using), |
There was a problem hiding this comment.
Wrong order. Variables in USING should appear before variables in SET.
Please first write test cases to expose the problem.
|
|
||
| private def extractVariablesFromEitherListLiteralOrBindMarker(table: Table, columnName: Identifier, literalOrBindMarker: Either[ListLiteral, BindMarker]): Result[Seq[DataType]] = { | ||
| literalOrBindMarker match { | ||
| case Left(listLiteral) => extractVariablesFromListLiteralAssignment(table, columnName, listLiteral) |
There was a problem hiding this comment.
Please add a todo to validate that column is actually a list.
| private def extractVariablesFromTermAssigment(table: Table, columnName: Identifier, updateOperator: Update.UpdateOperator, term: Term): Result[Seq[DataType]] = | ||
| table.getColumn(columnName).map(_.dataType).flatMap { | ||
| case DataType.List(t) => extractVariablesFromTerm(term, DataType.List(t)) | ||
| case DataType.Map(k, t) => extractVariablesFromTerm(term, DataType.Map(k, t)) |
|
@tabdulradi done, check the new commits please. |
|
Please write a test case for the variable order bug first. |
tabdulradi
approved these changes
Oct 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.