Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV Show not removed from library #38

Closed
4 of 11 tasks
Smeulf opened this issue Mar 31, 2019 · 6 comments
Closed
4 of 11 tasks

TV Show not removed from library #38

Smeulf opened this issue Mar 31, 2019 · 6 comments

Comments

@Smeulf
Copy link

Smeulf commented Mar 31, 2019

I'm submitting a ...

  • bug report
  • feature request
  • support request

General information

Removing an exported tvshow doesn't remove it from the Library

Addon version used

[0.14.0.beta23]

Steps to Reproduce

  1. Export a TV Show
  2. Remove the exported tv show

Expected behavior: [What you expected to happen]

TV show removed from library

Actual behavior: [What actually happened]

strm files are deleted
folders are deleted
tv show is not removed from the library

Context (Environment)

Installation

  • I'm using this Netflix Repo
  • I'm using other Netflix Repo (Please specify which)
  • I'm using a different source (Please tell which)

Operating System

  • Linux (x86/x64)
  • OSX (x86/x64)
  • Windows (x86/x64)
  • Linux (ARM)
  • Android

Additional informatin on the environment

Issue is platform independant, same problem on LibreELEC 9 or under Windows 10

Debug log

https://pastebin.com/u5JFWtfT

@CastagnaIT
Copy link
Owner

download the zip of addon from github master branch, I've already fixed the problem

@Smeulf
Copy link
Author

Smeulf commented Mar 31, 2019

I'm sorry but the issue remains :(

I also uninstalled the addon, reinstalled it from the master version, still the same issue.

The show is removed from the exported items list, but not from the Kodi library itself.

I can see many "Cannot automatically remove a season from Kodi library, please do it manually" every time I try, plus the log says "Cannot remove u'tvshowid' from Kodi library, Kodi does not support this (yet)". I doubt this is the normal behavior, but maybe I'm wrong ;)

A new log maybe : https://pastebin.com/vs8eHnRi

Cheers.

@CastagnaIT
Copy link
Owner

by "kodi library itself" you mean "Favourites"?
I tried several times but I could not reproduce your error

especially the Arrow TV series mentioned in your log is not on the netflix list...at least here in italy there isn't

I export a TV show, it appears on the exported list,
then I'm adding in favorites,
now if i delete it from the exported list, in the favorites remains, and that's normal, there is the appropriate menu to remove from the favorites.

do you take any different steps?

@Smeulf
Copy link
Author

Smeulf commented Mar 31, 2019

I don't use favorites, I use only the Kodi library.

Here's the steps:

  • Export TV show -> it appears in the exported list
  • Go to TV Show in Kodi main screen -> the exported tv show appears (as I added the show folder from the plugin addon_data folder to my sources list)
  • Go back to netflix addon, remove the show from library -> the strm files and folders are deleted
  • Go back to TV show in Kodi main menu -> the show is still there, but should have been removed automatically

Nevermind the show, "Arrow", "The O.A", or any other, the issue is the same ;(

If I'm correct, it should use JSON-RPC to perform a "VideoLibrary.RemoveTVShow", but I can't see this call anywhere in the logs.

@CastagnaIT
Copy link
Owner

I've had a different problem...

I tried to add lucifer and The o.a.
then i only removed The oa.

in netflix plugin when I removed The OA, also removed Lucifer ?!? I do not know why....
on the kodi library, instead result correct, The OA removed and lucifer is still present

there's a little study to be done to solve this problem...
when i have more free time, i'll do some tests

@Smeulf
Copy link
Author

Smeulf commented Mar 31, 2019

I ran the same test with The O.A first and Lucifer then. Removed The O.A.

Strm files were removed for the O.A. but Lucifer files are still there.

Both shows are still in the library.

No hurry on this, I still can remove them manually. Take the time you need!

Feel free to ask for any test you want, on this issue or any other.

Smeulf added a commit to Smeulf/plugin.video.netflix that referenced this issue Jun 19, 2019
- Fix CastagnaIT#38 (TV Show not removed from library).
- Scan only the addon strm output folder, for faster processing with large library. Use the service to perform the scan.
- Fix TV Show directory not deleted after the show is removed from library.
- Fix stmr filename in db to be fully compatible with NFS from Windows.
- Faster database fetching through API using filters.
- Fix progressbar while exporting/removing items to library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants