Implement index manifest collection for the containerd hostfs image type #133

domust · 2023-05-08T14:05:44Z

No description provided.

cmd/imgcollector/image/hostfs/containerd_image.go

w

cmd/imgcollector/image/remote.go

cmd/imgcollector/image/hostfs/containerd_image_test.go

Implement index manifest collection for the containerd hostfs image type

e6a6794

matas-cast reviewed May 8, 2023

View reviewed changes

cmd/imgcollector/image/hostfs/containerd_image.go Outdated Show resolved Hide resolved

matas-cast reviewed May 8, 2023

View reviewed changes

cmd/imgcollector/image/hostfs/containerd_image.go Outdated Show resolved Hide resolved

domust added 3 commits May 9, 2023 11:45

Reuse return value of resolveDigest instead of calling it multiple times

12d3021

Return a not implemented error for the rest of 3 image types.

04263ff

Log not implemented error for the Index method, but continue execution

770f147

domust marked this pull request as ready for review May 9, 2023 13:52

anjmao previously approved these changes May 9, 2023

View reviewed changes

cmd/imgcollector/image/hostfs/containerd_image.go Outdated Show resolved Hide resolved

anjmao self-requested a review May 9, 2023 14:07

domust requested a review from matas-cast May 9, 2023 14:08

anjmao reviewed May 9, 2023

View reviewed changes

cmd/imgcollector/image/remote.go Outdated Show resolved Hide resolved

domust added 2 commits May 10, 2023 09:21

Remove unnecessary error return values

dfa9e3c

Remove redundant methods

90af5d8

domust requested a review from anjmao May 10, 2023 07:26

anjmao approved these changes May 10, 2023

View reviewed changes

cmd/imgcollector/image/hostfs/containerd_image_test.go Outdated Show resolved Hide resolved

Update the tests

211787a

domust merged commit e3cbe6d into main May 10, 2023
2 checks passed

domust deleted the multiarch-image-architectures branch May 10, 2023 08:40

Provide feedback