Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder for sections 1 & 3 #8

Merged
merged 9 commits into from
Jun 4, 2023
Merged

Builder for sections 1 & 3 #8

merged 9 commits into from
Jun 4, 2023

Conversation

castelao
Copy link
Owner

@castelao castelao commented Jun 4, 2023

Implementing basic builder, and organizing core library with modules. It was getting too large.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2023

Codecov Report

Merging #8 (b0b3b2f) into main (b9111e7) will decrease coverage by 1.43%.
The diff coverage is 61.90%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   74.57%   73.15%   -1.43%     
==========================================
  Files           2        4       +2     
  Lines         535      555      +20     
==========================================
+ Hits          399      406       +7     
- Misses        136      149      +13     
Impacted Files Coverage Δ
bufr-lib/src/lib.rs 53.88% <60.00%> (-2.53%) ⬇️
bufr-lib/src/identification.rs 62.00% <62.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Don't need it in the core library but only in the module.
Skeleton for a builder.
@castelao castelao merged commit 382f496 into main Jun 4, 2023
8 checks passed
@castelao castelao deleted the builder branch June 4, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants