This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
upgrade to castle-rb 3 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
nijikon
force-pushed
the
upgrade-to-castle-rb-3
branch
from
36b028b
to
bdf6f2a
Compare
nijikon
force-pushed
the
upgrade-to-castle-rb-3
branch
from
2546864
to
355ce94
Compare
|
Since I have submitted this for review I can't give Github feedback. But this looks good, if you've tested this on the example application we should be good to ship this. Keep me posted! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.