Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASPNET Facilities Implementation #355

Closed
wants to merge 1 commit into from
Closed

ASPNET Facilities Implementation #355

wants to merge 1 commit into from

Conversation

@ghost ghost mentioned this pull request Oct 14, 2017
@ghost ghost changed the title ASPNET FACILITIES IMPLEMENTATION ASPNET Facility Implementation Oct 14, 2017
Documentation:

Index

- https://github.com/castleproject/Windsor/blob/master/docs/facilities.md

ASPNET FACILITIES

- https://github.com/castleproject/Windsor/blob/master/docs/systemweb-facility.md
- https://github.com/castleproject/Windsor/blob/master/docs/aspnetmvc-facility.md
- https://github.com/castleproject/Windsor/blob/master/docs/aspnetwebapi-facility.md

COMMIT LOGS(TXT)

Combined Refactoring and review with @jonorossi:

- More refactorings and changes after review from @jonorossi
- Updated facility to take advantage of fluent interface
- More docs tweaks
- Reverted docs
- More docs clean up
- Fixed wording in systemweb docs
- Fixed incorrect name in system web docs
- More tunes ups to system web
- Tuned up wording on system web docs
- Fixed up naming in the docs

Post PR Refactoring:

#283

Implemented some facility support:

- This was just to clean up what was there already. Small refactor.
- Also cleaned up exceptions to help steer users in the right direction.

#283 (comment)

Updated public API:

- It seems like we needed some synergy between the fact that web request lifestyles are bound to scopes.
- Initially I was against this but after thinking about I can see a valid point here. It is not easy for people who don't know the guts of Windsor.

#283 (comment)

Updated documentation for facilities:

- It was very clear that the examples and documentation needed a but of clarity about scoping and how transients work.
- Thanks @mario-d-s for your feedback

Implemented facility for ASPNET WebAPI

- Updated CHANGELOG.md
- Completed build process for webapi facility
- Updated docs
- Last minute testing and refactoring
- Tests are complete for both selfhost and webhost api
- Have a solution that supports self hosting and web hosted webapi
- WebApi facility dev complete
- Updated CHANGELOG.md again

Implemented facility for ASPNET MVC

- Updated CHANGELOG.md
- Fixed namespace that was incorrect
- Did build automation for facility
- Updated docs for aspnet mvc facility
- Dev complete adding the mvc facility

Implemented facility for ASPNET SystemWeb

- Removed build symbol from README.md
- Removed build symbol for SYSTEM_WEB
- Renamed system web namespace to include product 'AspNet'
- Made build pass and updated appveyor deployments
- Added some doco's ...
- Updated error report to include the new assembly
- Added missing package reference to Microsoft.Web.Infrastructure
- Added place holder for system web facility, just a copy of the logging facility docs
- Added link for system web facility
- Added some more notes to docs
- Removed per web request from lifestyles docs
- Updating installer documentation to not use per web request
- Made sure the generic implementation matching strategy does not reference per web request
- Adding CHANGELOG.md entry before I forget
- Added comment for better testing idea
- Bringing documentation into the solution
- Found more gubbins that needed moving
- A little more shifting
- Small refactor
- Completed the tests
- Ported testfixtures across to new test project, have the old test project compiling
- Moved all the code over, and starting to port the tests
- Started moving the microkernel lifestyles across for web requests
- Generate project stubs for facility
@ghost ghost changed the title ASPNET Facility Implementation ASPNET Facilities Implementation Oct 14, 2017
@ghost
Copy link
Author

ghost commented Oct 17, 2017

Will close this out as I think there is still some work to do on #351

@ghost ghost closed this Oct 17, 2017
@ghost ghost deleted the facilities-desktopclr-squished branch June 22, 2018 00:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants