Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XML configuration dictionary containing list of components throws exceptions #575

Merged
merged 6 commits into from
Dec 4, 2020
Merged

Fix XML configuration dictionary containing list of components throws exceptions #575

merged 6 commits into from
Dec 4, 2020

Conversation

ni-mi
Copy link
Contributor

@ni-mi ni-mi commented Nov 29, 2020

#574
Fix dictionary bug where reference to list components didn't work

@ni-mi ni-mi mentioned this pull request Nov 29, 2020
Closed
@ni-mi ni-mi marked this pull request as ready for review November 29, 2020 16:46
jonorossi
jonorossi requested changes Dec 3, 2020
View reviewed changes
Copy link
Member

@jonorossi jonorossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this to use ReferenceExpressionUtil, yep that is exactly what I was after. Just some minor review comments.

src/Castle.Windsor.Tests/Config/ConfigurationTestCase.cs Outdated Show resolved Hide resolved
src/Castle.Windsor.Tests/Config/ConfigurationTestCase.cs Outdated Show resolved Hide resolved
src/Castle.Windsor.Tests/Config/ConfigurationTestCase.cs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jonorossi jonorossi changed the title Fix bug decribed in https://github.com/castleproject/Windsor/issues/574 Fix XML configuration dictionary containing list of components throws exceptions Dec 3, 2020
@jonorossi jonorossi linked an issue Dec 3, 2020 that may be closed by this pull request
Dictionary with values of other components that are lists throws exceptions #574
Closed
@jonorossi
Copy link
Member

FYI, your commits are using an email address not linked to your GitHub profile. You might want to check if that is the address you intended to use, and fix if not.

@ni-mi
Copy link
Contributor Author

ni-mi commented Dec 4, 2020

FYI, your commits are using an email address not linked to your GitHub profile. You might want to check if that is the address you intended to use, and fix if not.

Thank you, I haven't noticed - changed that.

@ni-mi
Copy link
Contributor Author

ni-mi commented Dec 4, 2020

@jonorossi - please re-review :)
Also, I'd appreciate if you could let me know when you think you can release a version with those changes since they are blockers for us.

Thanks!

@jonorossi jonorossi added this to the vNext milestone Dec 4, 2020
@jonorossi jonorossi merged commit 9cad467 into castleproject:master Dec 4, 2020
@jonorossi jonorossi mentioned this pull request Dec 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonorossi jonorossi jonorossi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.1.1
Development

Successfully merging this pull request may close these issues.

Dictionary with values of other components that are lists throws exceptions
2 participants
@ni-mi @jonorossi