Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify SearchCollection and SearchMsmarco #1458

Closed
lintool opened this issue Jan 18, 2021 · 2 comments · Fixed by #1684
Closed

Unify SearchCollection and SearchMsmarco #1458

lintool opened this issue Jan 18, 2021 · 2 comments · Fixed by #1684

Comments

@lintool
Copy link
Member

lintool commented Jan 18, 2021

SearchCollection and SearchMsmarco have overlapping code paths: we should unify.
@lintool
Copy link
Member Author

lintool commented Jan 18, 2021

One nice feature of SearchMsmarco is multi-threaded execution.

SearchCollection has multi-threading also, but across runs - for efficient parameter sweeps, not intra-run (i.e., to execute a run faster).

@lintool
Copy link
Member Author

lintool commented Dec 3, 2021

Done! #1678

Documentation needs a bit of clean, e.g., SearchMsmarco still in places like here:
https://github.com/castorini/anserini/blob/master/docs/regressions-msmarco-doc.md

@lintool lintool mentioned this issue Dec 4, 2021
Merged
@m-hoseyny m-hoseyny mentioned this issue Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add explanation for the deprecation of SearchMsmarco castorini/anserini
1 participant
@lintool