Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version conflict: the doc of experiments-nfcorpus.md #1865

Closed
Adeshen opened this issue Apr 17, 2024 · 4 comments
Closed

version conflict: the doc of experiments-nfcorpus.md #1865

Adeshen opened this issue Apr 17, 2024 · 4 comments

Comments

@Adeshen
Copy link

Adeshen commented Apr 17, 2024

It says that

python -m pyserini.encode \
  input   --corpus collections/nfcorpus/corpus.jsonl \
          --fields title text \
  output  --embeddings indexes/nfcorpus.bge-base-en-v1.5 \
          --to-faiss \
  encoder --encoder BAAI/bge-base-en-v1.5 **--l2-norm** \
          --device cpu \
          --pooling mean \
          --fields title text \
          --batch 32

python -m pyserini.encode \
  input   --corpus collections/nfcorpus/corpus.jsonl \
          --fields title text \
  output  --embeddings indexes/nfcorpus.bge-base-en-v1.5 \
          --to-faiss \
  encoder --encoder BAAI/bge-base-en-v1.5 --l2-norm \
          --device cpu \
          --pooling mean \
          --fields title text \
          --batch 32

but in the latest version, it could find --l2-norm --pooling mean

I think the maintainers maybe forget the issue

@lintool
Copy link
Member

lintool commented Apr 17, 2024

@MXueguang this is related to a recent PR you worked on?

@Adeshen
Copy link
Author

Adeshen commented Apr 17, 2024 via email

@MXueguang
Copy link
Member

sorry @Adeshen, I didn't get what the issue is, could you explain a bit more details.

@lintool
Copy link
Member

lintool commented Jun 18, 2024

Having heard no further follow-up, closing.

@lintool lintool closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants