Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporating dense retrieval support in pyserini #258

Closed
lintool opened this issue Nov 23, 2020 · 1 comment
Closed

Incorporating dense retrieval support in pyserini #258

lintool opened this issue Nov 23, 2020 · 1 comment

Comments

@lintool
Copy link
Member

lintool commented Nov 23, 2020

There are four components we need to worry about:

  • (1) ANN search on the dense vector itself - indexing, retrieval, etc. This will require a dependency on faiss, hnsw, etc.
  • (2) query encoding. This will require a dependency on hgf, PyTorch, Tensorflow, etc.
  • (3) document encoding. This may be the same as (2) or may be different.
  • (4) code for learning the encoders. Obviously, this will have lots of dependencies.

My proposal is that (1) and (2) go directly into pyserini, (3) and (4) go into another repo. The rationale is that pyserini is a retrieval toolkit, and should only have the minimal amount of code necessary to perform dense retrieval, here, with "pre-built" vector encodings.

This means that pyserini will be burden with a longer dependency chain, but I don't really see a way around that...

@lintool
Copy link
Member Author

lintool commented Jan 5, 2021

Initial impl merged into Pyserini here: #278 🎉

@lintool lintool closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant