Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solargraph 0.46.0 breaks hover compatibility with Eglot #583

Closed
acdlbs opened this issue Aug 30, 2022 · 2 comments
Closed

Solargraph 0.46.0 breaks hover compatibility with Eglot #583

acdlbs opened this issue Aug 30, 2022 · 2 comments

Comments

@acdlbs
Copy link

acdlbs commented Aug 30, 2022

One of the changes in the Solargraph v0.46.0 release was:

Return nil value for empty hover contents

Eglot (version: 1.8) seems to be expecting a non-nil value (see issue 1019 - joaotavora/eglot#1019) on hover and is throwing errors every-time the cursor is on an empty line.
@castwide
Copy link
Owner

It looks like I misunderstood the spec. The textDocument/hover response can be null, but if it contains a Hover object, its contents should not be null. I'll fix it in a patch release.

castwide added a commit that referenced this issue Sep 5, 2022
@castwide
Nullify Hover object instead of contents value (#583)
d363269
@castwide castwide mentioned this issue Sep 5, 2022
Closed
@joaotavora joaotavora mentioned this issue Sep 8, 2022
Closed
@castwide
Copy link
Owner

Released in v0.47.0.

@castwide castwide closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acdlbs @castwide