fix(textarea-control): ace editor input exception (apache#18146)

casual-precision · Feb 10, 2022 · 6198508 · 6198508
1 parent 78dfcd8
commit 6198508
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/superset-frontend/src/explore/components/controls/TextAreaControl.jsx b/superset-frontend/src/explore/components/controls/TextAreaControl.jsx
@@ -63,6 +63,10 @@ export default class TextAreaControl extends React.Component {
     this.props.onChange(value);
   }
 
+  onAreaEditorChange(value) {
+    this.props.onChange(value);
+  }
+
   renderEditor(inModal = false) {
     const minLines = inModal ? 40 : this.props.minLines || 12;
     if (this.props.language) {
@@ -76,14 +80,14 @@ export default class TextAreaControl extends React.Component {
           style={style}
           minLines={minLines}
           maxLines={inModal ? 1000 : this.props.maxLines}
-          onChange={this.props.onChange}
           width="100%"
           height={`${minLines}em`}
           editorProps={{ $blockScrolling: true }}
           defaultValue={this.props.initialValue}
           readOnly={this.props.readOnly}
           key={this.props.name}
           {...this.props}
+          onChange={this.onAreaEditorChange.bind(this)}
         />
       );
     }

diff --git a/superset-frontend/src/explore/components/controls/TextAreaControl.test.jsx b/superset-frontend/src/explore/components/controls/TextAreaControl.test.jsx
@@ -54,4 +54,12 @@ describe('TextArea', () => {
     expect(wrapper.find(TextArea)).not.toExist();
     expect(wrapper.find(TextAreaEditor)).toExist();
   });
+
+  it('calls onAreaEditorChange when entering in the AceEditor', () => {
+    const props = { ...defaultProps };
+    props.language = 'markdown';
+    wrapper = shallow(<TextAreaControl {...props} />);
+    wrapper.simulate('change', { target: { value: 'x' } });
+    expect(defaultProps.onChange.calledWith('x')).toBe(true);
+  });
 });