Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startWeekWithSunday option #20

Merged
merged 4 commits into from May 30, 2022

Conversation

dmitry-kotorov
Copy link
Contributor

Not sure it is the best way to do that (may be better is to migrate to something like TZData), but works for me.

Copy link
Owner

@casvanluijtelaar casvanluijtelaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have a couple notes.

There seem to be quite a few formatting changes, make sure to do dart format . when you're done.

Secondly, Is Sunday the only alternative start day of a week? wouldn't it be better to just use an input parameter like int weekStartDay = Weekday.monday, so users can start the week at any day they want?

@dmitry-kotorov
Copy link
Contributor Author

Thanks for the PR! I have a couple notes.

There seem to be quite a few formatting changes, make sure to do dart format . when you're done.

Secondly, Is Sunday the only alternative start day of a week? wouldn't it be better to just use an input parameter like int weekStartDay = Weekday.monday, so users can start the week at any day they want?

As far as I know Sunday is the only option. I have an app that is localized in 53 languages and used in 100+ countries and I have never received requests from users for any other options) I also googled and didn't find any other options in the world.

@casvanluijtelaar casvanluijtelaar self-requested a review May 29, 2022 17:21
@casvanluijtelaar casvanluijtelaar merged commit 901e79c into casvanluijtelaar:master May 30, 2022
@casvanluijtelaar
Copy link
Owner

available in 1.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants