Rename package.metadata.generate-rpm.repository to url #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack parameter package.metadata.generate-rpm.homepage to it. The RPM variable "URL" is intended to store the URL of the package home page, not the repository URL. Therefore, the metadata key name is changed to "url" and set the fallback to "package.homepage" when the package key does not present. package.repository is also used for second fallback when neither package.metadata.generate-rpm.url nor package.homepage exists. Because today there is many projects where package.repository present but package.url not present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54 introduced package.metadata.generate-rpm.repository to specify URL of the rpm file. But, "URL" is intended to store the URL of the package home page, not the repository URL. So, package.metadata.generate-rpm.repository should be renamed to package.metadata.generate-rpm.url.
Due to same reason, its fallback should be "package.homepage". package.repository should be also used for second fallback when neither package.metadata.generate-rpm.url nor package.homepage exists. Because today there is many projects where package.repository present but package.url not present.