Add max duration for several effects lacking it #1465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Assign max duration to various effects that can easily stack to effectively-infinite duration without them"
Purpose of change
It was brought up on the BN discord that certain effects seem to have uncapped durations, which are kinda infamous for being lethal as hell as a consequence. This also ties in with the infamous "deaf for in-game weeks because big boom" issue, which I recall was fixed in DDA at some point by capping duration.
Describe the solution
max_duration
of 30 minutes to the blind, stunned, stun, poison, badpoison, paralyzepoison, sap, relax_gas effects. Most of these are effects that can either hypothetically stack up if a source is able to spam them, or more often gets doled out by a field and can thus easily ramp up to functionally infinite duration in a bad situation.max_duration
of 23 hours to food poisoning and deafness effects. These are effects meant to be doled out in fairly long durations it seems, but can hypothetically stack up to absurd durations, with deafness being infamous for this in particular. Realistically it seems temporary hearing loss can take 24-48 hours in some cases to clear up so this would be within that range to an acceptable degree.Describe alternatives you've considered
I was tempted to mess with mi-go atmosphere a lil too but I have a separate idea for that I might do in another PR.
Testing
Checked affected files for lint and syntax errors.
Additional context