Updates to putting self out when on fire #2335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Patting down fire has more impact, stop drop and roll triggers earlier"
Purpose of change
A thing @KheirFerrum looked into on the BN discord recently, it was found that the "attempt to put yourself out if on fire" behavior was a bit flawed. Part of it was because DoT from being on fire itself appears to be add more duration from it dealing
DT_HEAT
hits depending on the clothing worn, which is fair since clothing is good fuel.But where this became a problem was when it intersected with the code to try and put yourself out. The baseline reduction in duration does almost nothing, while the more effective "stop drop and roll" action was locked behind a threshold of more than a minute duration before your character would be willing to choose the (vastly more effective) option. Needless to say, your HP bar typically isn't going to last long enough for this to ever really be a factor.
Describe the solution
Combined, this should allow for situations where a single round of patting will negate being on fire if it's not that severe and thus letting you skip the turn loss from being knocked down, but any situation where the fire seems to escalate quickly prompts the more effective method to kick in.
Describe alternatives you've considered
Testing
One weird thing I noticed, when you stop drop and roll, your character tends to both repeatedly drop and struggle to get up at the same time.
Additional context