Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Find Antibiotics mission should also accept broad-spectrum antibiotics #2397

Merged
merged 8 commits into from
Apr 11, 2023
Merged

The Find Antibiotics mission should also accept broad-spectrum antibiotics #2397

merged 8 commits into from
Apr 11, 2023

Conversation

Zlorthishen
Copy link
Contributor

Summary

Summary(Bugfix) "The Find Antibiotics mission should also accept broad-spectrum antibiotics"

Purpose of change

The Find Antibiotics mission only accepts accepts vanilla antibiotics rather than all the things that might cure the infection.

Describe the solution

changes the mission to accept Strong Antibiotics, Panaceia and regular antibiotics, implements dda 47011 by langp11

Describe alternatives you've considered

Testing

Spawned an NPC with debug command, remove any existing mission. add "Find Antibiotics". Verify that items fulfill mission requirements.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Mar 8, 2023
@Zlorthishen Zlorthishen changed the title Update missiondef.json The Find Antibiotics mission should also accept broad-spectrum antibiotics Mar 8, 2023
@Zlorthishen Zlorthishen marked this pull request as ready for review March 8, 2023 20:46
@olanti-p
Copy link
Member

olanti-p commented Mar 8, 2023

Does the antibiotics item get removed from inventory on mission completion?

@Zlorthishen
Copy link
Contributor Author

Does the antibiotics item get removed from inventory on mission completion?

it does not. what would be a good way of removing them?

@chaosvolt
Copy link
Member

it does not. what would be a good way of removing them?

It'd have to be in the mission's end effects, but I'm not sure if conditional removal is a thing for that.

@Coolthulhu Coolthulhu self-assigned this Mar 9, 2023
@Coolthulhu
Copy link
Member

Certainly needs that removal bit.

@Coolthulhu Coolthulhu removed their assignment Mar 14, 2023
@olanti-p
Copy link
Member

What if you were instead to set the goal as MGOAL_FIND_ITEM_GROUP, define a custom item group that consists of the 3 items, and reference it in mission definition with "item_group": "the_3_options"?

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Zlorthishen
Copy link
Contributor Author

Zlorthishen commented Apr 2, 2023

What if you were instead to set the goal as MGOAL_FIND_ITEM_GROUP, define a custom item group that consists of the 3 items, and reference it in mission definition with "item_group": "the_3_options"?
cataclysm-tiles_2023-04-02_18-40-04

i tried implementing that, but not only does it not work, i also get this error.

Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Copy link
Member

@olanti-p olanti-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it works together with #2546

@olanti-p olanti-p merged commit e612a1b into cataclysmbnteam:upload Apr 11, 2023
@Zlorthishen Zlorthishen deleted the fix-antibiotics branch April 12, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants