Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CBM rebalance to make installation more accessible. #243

Closed
wants to merge 4 commits into from
Closed

[WIP] CBM rebalance to make installation more accessible. #243

wants to merge 4 commits into from

Conversation

Firestorm01X2
Copy link
Collaborator

@Firestorm01X2 Firestorm01X2 commented Nov 29, 2020

CBM rebalance to make installation more accessible.

Summary

SUMMARY: Balance "CBM rebalance to make installation more accessible."

Purpose of change

https://github.com/cataclysmbnteam/Cataclysm-BN/projects/3
#57

First step- making CBM more accessible.
For now used Aftershock approach with certain tweaks.

Describe the solution

Tasks:

  • Making Autodoc installation safer by increasing autodoc bonus.

Describe alternatives you've considered

None for now.

Testing

TODO

Additional context

None.

CBM rebalance
@Coolthulhu
Copy link
Member

Slot system isn't ready for enabling yet. The slots aren't balanced.
If the anesthesia system is disabled in core, it needs to be properly ripped out, not just suppressed.

Harvestable CBMs and slots will require their own PRs, since they are big.

Also:
To get checkmarks, you write * [ ] Text.
You should get a spellchecker in English.

firestorm01x2 added 3 commits November 29, 2020 21:08
lint
This reverts commit 84ba54d.
This reverts commit 670f690.
@Firestorm01X2
Copy link
Collaborator Author

Firestorm01X2 commented Nov 30, 2020

Ok. I need to think about approach a bit. I am starting to think that starting throwing away things like anastetic kits probably is not great idea now. Especially if we keeping slots from enabling for now.
Maybe we can work with current requirements after certain tweaking.

Overall idea is to make CBM more accessible. It can work even with anesthetic kits. It's just needs reviewing.

@Firestorm01X2 Firestorm01X2 changed the title [WIP] CBM rebalance using Aftershock approach [WIP] CBM rebalance to make installation more accessible. Nov 30, 2020
@Coolthulhu
Copy link
Member

Try to make PRs as specific as possible at first.
For example, "safe autodoc" mod, added to default mods, would be specific and achieve easier CBMs pretty quickly.

@Coolthulhu
Copy link
Member

You could easily make it a ~10 line thing by creating a "Guaranteed Autodoc Installation" mod, overriding autodoc in it, then adding it to data/mods/default.json.
Though it would be better to open a new PR, because this one has a history of commits.

@Firestorm01X2
Copy link
Collaborator Author

Firestorm01X2 commented Dec 10, 2020

You could easily make it a ~10 line thing by creating a "Guaranteed Autodoc Installation" mod, overriding autodoc in it, then adding it to data/mods/default.json.
Though it would be better to open a new PR, because this one has a history of commits.

Yeah. I should start from scratch.
I am thinking about not just making guranteed install but just buffing install chances via autodoc to the point where chances going to be quite hight but not 100% guranteed.

@Firestorm01X2 Firestorm01X2 deleted the cbm-rebalance-1 branch April 14, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants