Fix more segfault behaviour for turrets. #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turret shooting doesn't use aim_activity_actor at all.
KheirFerrum
changed the title
|
Checked manaul turet fire on humvee. It not crashing for me. |
scarf005
pushed a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Apr 2, 2023
Turret shooting doesn't use aim_activity_actor at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix more segfault behaviour for turrets."
Purpose of change
Fix #2468 causing issues with manually aimed turrets because they don't use the aim_activity_actor, so activity in target_ui leads to a nullptr.
Describe the solution
Removes that consideration entirely for turret aiming.
Describe alternatives you've considered
Make turrets route through same aim_activity_actor code.
Testing
Need to stand on the location of the turret in the vehicle part and fire it manually.
Additional context
Probably the worst PR I've screwed up yet.