Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: missing translation hotfix from #2519 #2602

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Apr 8, 2023

Summary

SUMMARY: Bugfixes "Missing translation hotfix from #2519"

Purpose of change

title text got changed to Play <N|n>ow! in #2519. however, other translation files haven't translated them (yet), hence test regression.

Describe the solution

test with <R|r>andom Character instead

Testing

Succeded after changing.
[2/2] Linking CXX executable /home/scarf/repo/cata/Cataclysm/cata_test-tiles
23:17:24.756 INFO : Randomness seeded to: 0
23:17:24.756 INFO : C locale on startup: 'ko_KR.UTF-8'
23:17:24.757 INFO : C++ locale on startup: 'ko_KR.UTF-8'
23:17:24.757 WARNING : Failed to detect system UI language.
23:17:24.757 INFO : Number of render drivers on your system: 3
23:17:24.757 INFO : Render driver: 0/opengl
23:17:24.757 INFO : Render driver: 1/opengles2
23:17:24.757 INFO : Render driver: 2/software

Starting the actual test at Sat Apr  8 23:17:29 2023
Filters: translations_actually_translate
23:17:29.379 INFO : Language set to 'en_US'
23:17:29.379 INFO : C locale set to 'en_US.UTF-8'
23:17:29.379 INFO : C++ locale set to 'en_US.UTF-8'
23:17:29.506 INFO : Language set to 'fr_FR'
23:17:29.506 INFO : C locale set to 'en_US.UTF-8'
23:17:29.506 INFO : C++ locale set to 'en_US.UTF-8'
23:17:29.649 INFO : Language set to 'ru_RU'
23:17:29.649 INFO : C locale set to 'en_US.UTF-8'
23:17:29.649 INFO : C++ locale set to 'en_US.UTF-8'
23:17:29.752 INFO : Language set to 'en'
23:17:29.752 INFO : C locale set to 'ko_KR.UTF-8'
23:17:29.752 INFO : C++ locale set to 'ko_KR.UTF-8'
===============================================================================
All tests passed (9 assertions in 1 test case)

Ended test at Sat Apr  8 23:17:29 2023
The test took 0.501 seconds

@github-actions github-actions bot added the tests PR changes related to tests label Apr 8, 2023
@scarf005 scarf005 merged commit c5990d2 into cataclysmbnteam:upload Apr 8, 2023
@scarf005 scarf005 deleted the translations-hotfix branch August 22, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests PR changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant