Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance" Tone down book spam of Specific Use Storage book itemgroup collections, bundle more book spawns into distributions in said collections"
Purpose of change
Another entry in the "makin' SUS less sus" series, this time targeting specialized bookcase spawns. Fixes #2626
Describe the solution
Updated and overall reduced spawns of books in data/json/itemgroups/SUS/library.json. In general magazines lean towards 1-3 spawns at 75% chance, standard textbooks/manuals lean towards 1 or 1-2 spawns at 50% chance, and top-tier or specialist books as low as 1 spawn at 25% chance.
Itemgroups with a huge number of potential spawns have also had more uses of distributions inside them, aimed at condensing spawns of similar-themed books into a single attempt to spawn one of each.
SUS_field_manual_bookcase
also had a couple related manuals added to the collection to add more variety, books specifically noted to be books for military use but aren't explicitly FMs or TMs. Doesn't matter in practice since the mil-surp store is the only place that even uses that itemgroup.Describe alternatives you've considered
Converting all of them into pure distributions instead of collections, requiring every spawn of them in mapgen to be edited to call them multiple times.
Testing
Checked affected file for syntax and lint errors.
The infamous tailoring bookcase, before:
![image](https://user-images.githubusercontent.com/11582235/235234458-14ed19dc-5265-4c26-9dfb-bc0e77ef363f.png)
And after:
![image](https://user-images.githubusercontent.com/11582235/235234884-3b0863ed-5bed-4354-b45b-100f7e87b341.png)
Additional context