Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aftershock butcher fixes #2649

Merged

Conversation

RoyalFox2140
Copy link
Contributor

SUMMARY: [Bugfixes] "Fixes invalid harvest targets in uplifted Aftershock animals"

Purpose of change

The uplifted animals from Aftershock had invalid harvests, and butchered into nothing. This replaces those with their mammal equivalents.

Describe the solution

I replaced demihuman_fur and demihuman_large_fur with mammal_fur and mammal_large_fur to make them have a valid harvest target, so butchery could work.

Describe alternatives you've considered

Demihuman seems to imply they are closer to human, so maybe it should be cannibalism. I see no reason why it would be considered cannibalism however, an uplifted bear is still a bear. An uplifted monkey is more questionable and maybe that one could be close enough to cannibalism.

Testing

I changed the JSON, launched the game with it, and butchered the 3 animals in question. No crashes, butchery worked.

Additional context

Aftershock is pain.

fixed harvests to allow butchery
@github-actions github-actions bot added data PRs related to datas. Won't crash game (probably) mods PR changes related to mods. labels Apr 16, 2023
Copy link
Contributor

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to actually work as intended you'd need to port over Strict Humanism from DDA.

@RoyalFox2140
Copy link
Contributor Author

For this to actually work as intended you'd need to port over Strict Humanism from DDA.

As humans already eat monkeys and a number of other animals such as dolphins, I see no compelling reason to feel bad about it or a significant enough difference in these humanoid bears and more human monkeys. If someone wants to port Strict Humanitarian after this PR they can, but vegetarian already covers feeling bad about eating animals.

It's also out of my abilities as a JSON edit.

@chaosvolt
Copy link
Member

Personally I'd just lump mutant humanoid meat under the effects of Cannibal and Psychopath rather than creating a trait just for a fairly narrow range of comestibles.

@scarf005 scarf005 merged commit a1b8b8b into cataclysmbnteam:upload Apr 16, 2023
@RoyalFox2140 RoyalFox2140 deleted the Aftershock-butcher-fixes branch June 6, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably) mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants