-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow installing non-sterile CBM when Infection Immune
#2671
Conversation
I forgot to make it in my PR, but I recommend to update the bionic's description and mention that it will allow user to make intrusive surgery operations with non-sterile tools. Or maybe maximum directly: you can install non-sterile bionics. |
thanks for the suggestion. as CBM implements Non-Sterile using faults as in #1665, they will be displayed via this loop: Lines 3818 to 3824 in 5343c28
i think there's some possibilities to handling this situation:
{
"id": "fault_bionic_nonsterile",
"type": "fault",
"name": { "str": "Non-sterile" },
"description": "This bionic needs to be sterilized before it can be installed.",
"nagated_by": [ "INFRESIST" ] // <- case 1
"nagated_by": [ { "type": "trait", "value": "INFRESIST" } ] // <- also check for types?
}
|
Nice idea. |
Almost everything works correctly: autodoc installs all function as expected (tested various combos of with and without Deadened and Infection Immune to ensure anesthesia interactions all still work) but attempting to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to be a dead-easy two line change in another file so instead of holding this up I'll implement the Manual Bionic Installation version of this in a follow-up PR.
Summary
SUMMARY: Features "allow installing non-sterile CBM when
Infection Immune
"Purpose of change
inspired by Cataclysm-TISH-team/Cataclysm-TISH#60
Describe the solution
Infection Immune
(INFRESIST) trait will ignore checking for CBM sterileness.Testing
Infection Immune
Infection Immune