refactor: registering actions/categories in action.cpp

[scarf005]

Summary

SUMMARY: Infrastructure "Refactor registering actions/categories in action.cpp"

Purpose of change

i was bored and the code looked bad.

Describe the solution

replaced REGISTER_ACTION and REGISTER_CATEGORY macro with make_register_actions and make_register_categories.

they are curried functions which capture state then return another function which you can conveniently name register_actions and register_categories. pass it a set and you're good to go. also, it should be fairly performant because it's rvalue refed and uses std::transform under the hood.

Describe alternatives you've considered

put registering action and action for it in same function, because current system is very bug prone

// before

register("SOME_KEY");
// ...
if ( key == "SOME_KEY" ) {
	// do something
}

// after
register("SOME_KEY", [&]() -> void {
	// do something
})

Testing

idk i guess it'd pass tests?

Additional context

[joveeater]

Sorry I totally missed this. This looks great. Much cleaner now.