Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the requirement for shallow pit for junk metal walls #2695

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

MrLostman
Copy link
Contributor

@MrLostman MrLostman commented Apr 25, 2023

Summary

SUMMARY: Balance "Remove the requirement for shallow pit for junk metal walls"

Purpose of change

To allow players to construct their dream slum.

Describe the solution

The requirement for shallow pits means junk metal walls can only be built on dirt tiles this substantially limits their use. There is no makeshift wall that can be used on floor tiles and the junk metal walls are an excellent fill for this roll.

Testing

  1. constructed, deconstructed & smashed the wall
  2. tested building in different spots to make sure there wasn't any unwanted behavior

Additional context

@github-actions github-actions bot added the data PRs related to datas. Won't crash game (probably) label Apr 25, 2023
@scarf005 scarf005 changed the title Removes junk metal walls requirment for a shallow pit Remove the requirement for shallow pit for junk metal walls Apr 25, 2023
@scarf005 scarf005 changed the title Remove the requirement for shallow pit for junk metal walls Remove the requirement for shallow pit for junk metal barrier Apr 25, 2023
@scarf005 scarf005 self-requested a review April 25, 2023 08:34
@scarf005 scarf005 changed the title Remove the requirement for shallow pit for junk metal barrier Remove the requirement for shallow pit for junk metal walls Apr 25, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

Cataclysm: Bright Nights - cbn-experimental-2023-04-24-2035-1-g335202b98cce_01
Cataclysm: Bright Nights - cbn-experimental-2023-04-24-2035-1-g335202b98cce_02
Cataclysm: Bright Nights - cbn-experimental-2023-04-24-2035-1-g335202b98cce_03

i don't see why junk walls cannot be constructed on floor. the tiles look a bit weird, tho.

Cataclysm: Bright Nights - cbn-experimental-2023-04-24-2035-1-g335202b98cce_04
Cataclysm: Bright Nights - cbn-experimental-2023-04-24-2035-1-g335202b98cce_05
digging requirement changes on faction camp also works as intended.

@scarf005 scarf005 merged commit 353a719 into cataclysmbnteam:upload Apr 25, 2023
14 checks passed
@MrLostman MrLostman deleted the junkmetal-walls-no-pit branch April 25, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants