feat(content): allow rocks for (staff) sling, add {big,small} lead sling bullets #2709
Conversation
github-actions
bot
added
the
data
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
data/json/recipes/ammo/other.json
Outdated
| "subcategory": "CSC_AMMO_OTHER", | ||
| "skill_used": "fabrication", | ||
| "difficulty": 3, | ||
| "time": "1 h", |
There was a problem hiding this comment.
Both these recipes can probably be made more granular, divided up to make 1 charge at a time for proportionately less time and material cost.
There was a problem hiding this comment.
I intended to keep it at the same standard for ball bearings where you made a bunch at once, but that's probably a good idea.
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
|
Sheesh. I keep screwing this stuff up. I appreciate the help, guys. |
data/json/items/ammo.json
Outdated
| "description": "A ball of lead roughly the size of a baseball. Traditionally thrown from a sling, and hits a lot harder than any old rock.", | ||
| "material": "lead", | ||
| "ammo_type": "rock", | ||
| "weight": "28 g", |
There was a problem hiding this comment.
50 units of lead per charge of sling_bullet would be 150 grams. Even then that's pretty light compared to regular rocks being 657 grams. But then again that's way over a whole pound, so honestly going for a value in the neighborhood of 150 grams and 50 ml would be good enough to match the lead item's density without having to tweak the recipe any further.
data/json/items/ammo.json
Outdated
| "description": "A small ball of lead traditionally thrown from a sling. It hits a lot harder than any old pebble.", | ||
| "material": "lead", | ||
| "ammo_type": "pebble", | ||
| "weight": "12 g", |
There was a problem hiding this comment.
Similar deal with the other item, recipe uses 150 grams of lead to make 6 shots, so would make sense to use 25 grams as weight. Possibly also dragging count down to only 30, so a stack of 250 ml weights 750 grams (again making it consistent with lead itself).
There was a problem hiding this comment.
Bug reported in previous review got fixed so dunno why it's still showing as changes requested, guess I can mark it as dismissed or whatever's needed to clear it.
- Load-tested JSON changes in compiled test build.
- Spawned in pebbles, rocks, and both sizes of sling bullet.
- Spawned a sling and staff sling, confirmed that both can load all four ammo items.
Ranges also match that of pebbles and rocks, but honestly it's already weird that pebbles and rocks also have the exact same range so I feel like that's a completely separate issue anyway. Looks good to me.
|
No worries. Will merge once it shows all green just in case I missed anything then, so long as lightning continues to fuck off and not affect my power or net. >:C |
scarf005
changed the title
scarf005
changed the title
|
oh hecc, forgot to mention without |
forgot to mention them in cataclysmbnteam#2709
forgot to mention them in #2709
Summary
SUMMARY: Content "Changed sling and staff sling to be capable of using both rocks and pebbles as ammo, as well as added in new 'sling bullet' and 'small sling bullet' ammo as a higher-end lead ammo for slings and staff slings."
Purpose of change
Slings have been used to huck larger rocks historically, and staff slings are just a sling on the end of a staff. Furthermore, lead sling bullets are historically accurate and would serve as a nice alternative to ball bearings.
Describe the solution
It's a minor change to two items, two new items, and two new recipes.
Describe alternatives you've considered
You could keep the staff sling and sling as using rocks and pebbles respectively, but it's kind of a strange distinction to begin with.
Testing
I've made sure there are no json errors and it seems fairly balanced in terms of stats and crafting.