Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): metric bullets part 2: rename .308 -> 7.62x51mm #2724

Merged
merged 2 commits into from
Apr 29, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Apr 29, 2023

Summary

SUMMARY: I18N "metric bullets part 2: rename .308 -> 7.62x51mm"

Purpose of change

part 2 of #2690.

Describe the solution

same as #2691.

  • changed Ammunition Type name of 308 to 7.62x51mm.
  • refined 7.62mm to 7.62x51mm as there's also 7.62x39mm which may be confusing
  • renamed .308 Winchester to 7.62x51mm '.308 Winchester'

Testing

Cataclysm: Bright Nights - cbn-experimental-2023-04-29-0219-1-g5be6d1b9370e_02
all .223 and 7.62x51mm rounds can be searched in single keyword 7.62x51mm.

Cataclysm: Bright Nights - cbn-experimental-2023-04-29-0219-1-g5be6d1b9370e_01
.308.

since there's many 7.62mm calibre rounds with different lengths.
@github-actions github-actions bot added data PRs related to datas. Won't crash game (probably) mods PR changes related to mods. tests PR changes related to tests labels Apr 29, 2023
@scarf005 scarf005 requested a review from chaosvolt April 29, 2023 03:26
@scarf005 scarf005 mentioned this pull request Apr 29, 2023
@scarf005 scarf005 merged commit 4aceff1 into cataclysmbnteam:upload Apr 29, 2023
18 checks passed
@scarf005 scarf005 deleted the metric-rounds-7.62 branch April 29, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably) mods PR changes related to mods. tests PR changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants