Weapon Value Caches properly update

[KheirFerrum]

Summary

SUMMARY: Bugfixes "Weapon Value Caches properly update"

Purpose of change

#1705 revealed issues with weapon value cache for NPCs, where they try to store and read ideal and current values, leading to mismatch and incorrect evaluations.

Describe the solution

Adds new wielded_value() function dedicated to updating value of currently wielded weapon. Accepts Character and bool as arguments, where the bool decides whether the value to be retrieved is the ideal value if the NPC had access to "infinite" ammo (set to magazine size otherwise values can get absurd).

Refactors wield_better_weapon() to solve secondary issue @scarf005 noticed in #1705 where NPC would swap to bionic weapon only to swap back due to how weapon swapping occurs in both check_or_use_weapon_cbms() and wield_better_weapon(). Now weapon swapping can only occur in wield_better_weapon(), check_or_use_weapon_cbms() instead queues the cbm weapon for checking.

Describe alternatives you've considered

Can't think of any.

Testing

Spawn NPC, give them a katana, an M4A1, a filled STANAG 20 round magazine, 50 5.56 NATO rounds, 6 00 shotshells, and then install the bionic shotgun into them.

• Spawn menacing debug monster within range. Check that the NPC wields their M4A1.
• Check that NPC empties first magazine, then swaps magazines and continues to fire
  • Check that NPC does not try to reload empty magazines during combat.
• Check that NPC then swaps to bionic shotgun once ammo sufficiently depleted and shoots until they run out of ammo
  • Check that NPC, having emptied the bionic shotgun's magazine, loads ammo one at a time and shoots the monster after each load.
• Check that once bionic shotgun is emptied (and NPC swaps back to M4A1 and fully empties that.) NPC swaps to katana.

Additional context

Note, NPC will not empty the M4A1 on their last mag but leave it on 1 bullet remaining, fixing this is somewhat out of scope, as it requires adding consideration for reload cost, weapon swap cost, and firing cost.

[scarf005]

NPC's inventory

output.mp4

I'm not sure why but the weapon switch of death (WSOD) still happens. could you check again?

this is my save with NPC setup for test.
EmptyWorld.zip

[scarf005]

Spawn menacing debug monster within range. Check that the NPC wields their M4A1.

2023-05-04.09-28-26.mp4

using the same save. this time, npc only wields katana, despite having m4a1.

[scarf005]

cache.mp4

confirmed that the npc

1. wields and fires m4a1 rifle first, and reloaded only once.

npc only reloaded empty magazine after combat.

2. wields and fires their bionic shotgun until emptying magazine, then loads and fires ammo one at a time.
3. uses their katana.

---

npc logic is still very wacky and sometimes they whack debug monster with m4a1 instead of their katana, but let's fix them later.

[scarf005]

interesting. (godbolt)

#include <array>
#include <iostream>

auto main() -> int {
    const auto a = int{123};
    const auto b = int{100};
    const auto c = float{100};

    std::cout << "123 / 100 :: int = " << float{a / b} << "\n";
    std::cout << "123 / 100 :: float = " << float{a / c} << "\n";
}
/*
123 / 100 :: int = 1
123 / 100 :: float = 1.23
*/