Allow debug menu to directly spawn irremovable item mods #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can now spawn irremovable mods directly onto the player via debug menu. Streamline wish for non-count_by_charges()
KheirFerrum
changed the title
KheirFerrum
changed the title
scarf005
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Allow debug menu to directly spawn irremovable item mods"
Purpose of change
Requiring people to debug spawn irremovable item/gun mods like conversion kits via map editor is unintuitive and annoying.
Describe the solution
Removes that consideration in
i_add_or_drop(). Instead the check is done directly on mod removal. Also updates the wish function for non-count_by_charges items to be slightly more efficient.Describe alternatives you've considered
Testing
Spawn conversion mods without issue. Still can't uninstall irremovable mods.
Additional context
Game doesn't even allow you to try to uninstall irremovable mods, so this seems somewhat extraneous.