-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steam turbine vehiclepart and power plant location #2815
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data
PRs related to datas. Won't crash game (probably)
label
May 12, 2023
Those were just visual indicators I left in by mistake while planning where the roof chunk should go, derp.
scarf005
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Add high-power steam turbine engine, small power plant overmap special as a special spawn"
Purpose of change
An additional thing I had in mind, with the goal of adding a high-tier engine option for steam engines, which are generaly fairly rare outside of the underwhelming craftable version.
Describe the solution
Describe alternatives you've considered
Adding pipe terrain/furniture specifically for implying pumping of natural gas and/or petroleum. Right now sewage pipes are used as a standin for that, something also done in locations like the private airport.
Nuclear power plants, solar farms, and wind farms likely would make more sense as separate overmap specials since the floorplan will vary too much for a single corner to cover it, plus logically we could mainline Aftershock's nuclear plants in the process.
Testing
Checked affected files for syntax and lint errors. More testing to follow as implementation progresses.
Worth noting: the other steam engines yield filled bottles of water when smashed, hence this was omitted from the bash results of the steam turbine vehicepart for now.
Additional context