Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steam turbine vehiclepart and power plant location #2815

Merged
merged 19 commits into from
May 22, 2023

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented May 12, 2023

Summary

SUMMARY: Content "Add high-power steam turbine engine, small power plant overmap special as a special spawn"

Purpose of change

An additional thing I had in mind, with the goal of adding a high-tier engine option for steam engines, which are generaly fairly rare outside of the underwhelming craftable version.

Describe the solution

  • Added item definition for steam turbine part. Its listed horsepower is based on what seemed like a good middle-ground value given steam turbines have a fairly massive range of power outputs, and I figured this would make sense for a value that's significantly above the other steam engines while being about half the value of the smallest gas turbine. Its sheer bulk meanwhile was derived via a rough estimate of the difference in size between the V12 gasoline engine and the small gas turbine, as applied to the size of the medium steam engine. Also fits steam turbine engines, especially for power plants, generally being pretty big.
  • Added vehiclepart definition for steam turbine. Efficiency is based off how gas turbine engines have 5% lower efficiency than regular gasoline engines, as applied to the efficiency rating of normal steam engines. This also helps differentiate it better from the heavier diesel engines, as making the efficiency scale down more would put its power stats a lot closer to that of the V12 diesel engine. Also gains the benefit added to turbine engines and giant motors.
  • Added a furniture definition that can be deconstructed to obtain a steam turbine. This is planned to see use in the new power plant location, as detailed below.
  • Add the mapgen files for power plant. Front half has a parking lot and the main office/workshop build, partially modeled after the sewage treatment plant's design. The back half has fuel storage/processing, the main turbine and generator, and finally a small amount of electrical substation equipment. The southwest corner has variations depending on type of fuel, with coal, natural gas (with chance of a burning gas leak), petroleum, and geothermal (based of speculative proposals to test injection well geothermal methods in New England, also with a chance of some seismic activity disrupting the surface) as potential options.
  • Added mapgen chunks for chance of something having gone wrong in two of the power plant variants.
  • Add mapgen palette for power plant (basically done aside from item mapping).
  • Added overmap terrain entries for power plant location.
  • Add overmap special for power plant.
  • Found places to fit steam turbine furniture into the shipwreck and Aftershock's municipal reactor.

Describe alternatives you've considered

Adding pipe terrain/furniture specifically for implying pumping of natural gas and/or petroleum. Right now sewage pipes are used as a standin for that, something also done in locations like the private airport.

Nuclear power plants, solar farms, and wind farms likely would make more sense as separate overmap specials since the floorplan will vary too much for a single corner to cover it, plus logically we could mainline Aftershock's nuclear plants in the process.

Testing

Checked affected files for syntax and lint errors. More testing to follow as implementation progresses.

Worth noting: the other steam engines yield filled bottles of water when smashed, hence this was omitted from the bash results of the steam turbine vehicepart for now.

image

Additional context

image

image

@github-actions github-actions bot added the data PRs related to datas. Won't crash game (probably) label May 12, 2023
@github-actions github-actions bot added the mods PR changes related to mods. label May 14, 2023
@chaosvolt chaosvolt marked this pull request as ready for review May 14, 2023 00:18
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

destroying 750hp steam turbine
image

shipwreck
image

small power plant
image

aftershock municipal reactor
image

@chaosvolt chaosvolt merged commit ac9710c into cataclysmbnteam:upload May 22, 2023
14 checks passed
@chaosvolt chaosvolt deleted the steamed-hams branch May 22, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably) mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants