Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity-check microlab leech plant spawns #2826

Merged
merged 2 commits into from
May 15, 2023

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented May 15, 2023

Summary

SUMMARY: Balance "Reduce spawn chance of leech stalks and leech pod clusters in microlab variant so there isn't literally 77 monsters packed in a single map tile"

Purpose of change

I stumbled on another weird case of wacky leech plant spawns, turns out the microlab spawn just pre-generates a giant horde with fixed spawns. Given the player has to reach them in the first place, they should already have plenty enough time in the reality bubble to generate critters and propagate without needing such a massive assist.

Describe the solution

  1. Axed the weird (and broken, since it sprinkles random cupboards all over the place) tile-based spawns of leech plants with use of place_monster, toning it down to 5-10 each of leech stalks and leech pod clusters (down from 32 and 44 respectively), plus the fixed spawn of the leech blossom.
  2. Misc: Shifted the corpse spawns to a 5% chance on standard floor tiles, since the tile-based spawns they used got axed per above.

Describe alternatives you've considered

Converting the weird janky spawn-in-specific-spots-by-tile nonsense into some place_monster spawns allowing us to set exactly the min and max number we want, along with letting us define an area for them to spawn in instead of this weird tile-based method.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Load-tested and visited microlabs until I found the leech plant variant, found the results to look tolerable.

Before:
image

After (spawned in via map editor so I could sift through variants without teleporting to microlabs constantly):
image

Additional context

@github-actions github-actions bot added the data PRs related to datas. Won't crash game (probably) label May 15, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

still the glass door on right of the reactors and cabinets are somewhat suspicious but let's worry about them later.

@scarf005 scarf005 merged commit b8f7918 into cataclysmbnteam:upload May 15, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants