fix: only NPCs drop items when overencumbered #3387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Only NPCs should be dropping items automatically when overencumbered"
Purpose of change
Fixes issue with the speed test errors mentioned by Olanti here
Only NPCs should be dropping items automatically when overencumbered. The player should not. The player can continue to just tumble items out if over volume capacity like they have been for a long time.
Describe the solution
Add an early out of the function if Character is not an NPC.
Describe alternatives you've considered
Leave the player automatically dropping items, modify test to add a fake activity target. That wouldn't have actually fixed the issue though.
Testing
Compiled, ran relevant tests, they passed.
Additional context
I need to be more on the ball about running the test suite for regressions.