Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only NPCs drop items when overencumbered #3387

Merged

Conversation

OrenAudeles
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Only NPCs should be dropping items automatically when overencumbered"

Purpose of change

Fixes issue with the speed test errors mentioned by Olanti here

Only NPCs should be dropping items automatically when overencumbered. The player should not. The player can continue to just tumble items out if over volume capacity like they have been for a long time.

Describe the solution

Add an early out of the function if Character is not an NPC.

Describe alternatives you've considered

Leave the player automatically dropping items, modify test to add a fake activity target. That wouldn't have actually fixed the issue though.

Testing

Compiled, ran relevant tests, they passed.

Additional context

I need to be more on the ball about running the test suite for regressions.

@olanti-p olanti-p added this pull request to the merge queue Oct 7, 2023
Merged via the queue into cataclysmbnteam:upload with commit 72c69cb Oct 7, 2023
7 of 15 checks passed
@OrenAudeles OrenAudeles deleted the fix-player-encumber-drop branch October 8, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src PR changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants