fix: books < 12.5mL may crash on disassembly #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
approved these changes
Oct 9, 2023
Merged
via the queue into
cataclysmbnteam:upload
with commit Oct 9, 2023
2bc98a8
7 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix FPE on disassembly of very low volume books"
Purpose of change
Fixes #3400 where we get an FPE due to autogenned book uncraft recipe time being directly correlated to volume.
Describe the solution
Force autogen book uncraft recipes to assume at least 1 page of output regardless of item volume when calculating time required to uncraft.
Describe alternatives you've considered
Testing
Spawned a few books along with
computer printoutwhich is in the sub-12.5mL volume FPE induction zone. Butchered them all. No crash.