Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): more improvements to visibility of bionic scanning #3977

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

chaosvolt
Copy link
Member

Purpose of change

This implements yet more adjustments and improvements related to harvesting bionics.

Describe the solution

  1. In game.cpp, set add_corpses so that the butchery menu's list of monster corpses visually marks corpses that have CBMs detected in them, showing them with the same (bionic detected) text on the end like their item form does. This makes it easier to remember which ones out of a pile of bodies have had a CBM detected.
  2. In item.cpp, changed item::tname so that scanned corpses gain a either (scanned) or (bionic detected) depending on if they have a bionic in then. This helps the player actually tell that the scanner is working by marking corpses that've been scanned but have no CBMs in them.

Describe alternatives you've considered

Screaming.

Testing

  1. Compiled and load-tested.
  2. Spawned in and debug-killed a bunch of shocker zombies.
  3. Scanned the pile with a bionic scanner.
  4. Corpses without bionics showed as scanned, ones with bionics showed the usual tagtext.
  5. Stood over a pile, some correctly show the info alongside the monster name.
  6. Separated them into two piles for with and without CBMs detected.
  7. Confirmed that the pile of ones with detected CBMs all show the added text in butchery menu, while the ones only marked as scanned don't.
  8. Made sure only the corpses could show as scanned and not the items nearby.
  9. Murdered my NPC friend, his body also shows as scanned after running by with the scanner active.
  10. Checked affected files for astyle.

Additional context

image
image

Checklist

@github-actions github-actions bot added the src PR changes related to source code. label Dec 25, 2023
@scarf005 scarf005 self-assigned this Dec 25, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

that's a great QOL improvement.

@scarf005 scarf005 changed the title fix: more improvements to visibility of bionic scanning fix(UI): more improvements to visibility of bionic scanning Dec 25, 2023
@scarf005 scarf005 merged commit 278b433 into cataclysmbnteam:main Dec 25, 2023
12 checks passed
@chaosvolt chaosvolt deleted the more-bionic-hassle branch December 26, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src PR changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants