-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content): shoulder holsters #3981
Conversation
The Autofix app has automatically formatted this Pull Request. If you edit your PR on web UI, you can ignore this message.
If you don't do this, your following work will be based on the old commit, and cause MERGE CONFLICT. |
PS. seems to be something about #3975 in the automated change for some reason. |
40fcd78
to
08d6d57
Compare
Now that I've had a think about it I'm wondering if it's better thematically to have it strapped with compact flag so it doesn't affect other commonly strapped arm armor |
Reasonable ye, consistent with stuff like back holsters having compact to avoid clashing with backpacks since balance-wise it undermines their utility. |
If we could keep both flags thatd be preferable tbh. If only because mutants not being able to craft one in their size doesnt make a whole lot of sense. |
That's a reasonable position - I'll keep it to strapped, compact (so it doesn't interfere with other strapped items), and oversize (so mutants can wear it). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:3
Adds the ability to create and find shoulder holsters like a cool 90s cop.
8d1c316
to
a81e8b3
Compare
Purpose of change
Adds the ability to create and find shoulder holsters like a cool 90s cop and/or super spy.
Describe the solution
You can make a holster that sits under your arm. Copied mostly from the existing holster item with some caveats:
Describe alternatives you've considered
This is too cool not to have in the game.
Testing
Additional context
Reviewers - may need to your assistance to make sure I've put in the correct values for distribution, not too familiar with those jsons.