Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): further use of resized_large #4004

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Dec 28, 2023

Purpose of change

This adds, as expected, some additional use of the new XL clothing mod.

Describe the solution

  • Added support for the resized_large clothing mod to the following items, all of these being non-varsize non-oversize items made of soft fabric that I figured could reasonably be altered:
List:
  • Clown shoes
  • Magazine satchel
  • Chest magazine pouch
  • Chest rig
  • Tac vest
  • Firefighter belt
  • Judo belts in general
  • Leather belt
  • Police duty belt
  • Tool belt
  • Webbing belt
  • Wrist bandolier
  • Hand grenade pouch
  • Paper arm guards
  • Elbow pads
  • Fencing gauntlets in general
  • Fur gloves
  • Light gloves
  • Winter gloves
  • Wool gloves
  • Work gloves
  • Army winter gloves
  • Emergency jacket
  • Eboshi
  • Baseball cap
  • Toque
  • Fur hat
  • Sombrero
  • Kippah
  • Kufi
  • Mail carrier hat
  • Golfcap
  • Pickelhaube
  • Deep concealment holster
  • Survivor harness
  • Leather chaps
  • Knee pads
  • Fencing mask
  • Dust mask
  • Guy Fawkes mask
  • Hockey mask
  • Backpack
  • Giant novelty backpack
  • Leather backpack
  • Dive bag
  • Duffel bag
  • Tactical dump pouch
  • Fanny pack
  • Drop leg pouches
  • Makeshift knapsack
  • Messenger bag
  • MOLLE pack
  • Petpack
  • Purse
  • Rucksack
  • Runner pack
  • Sling pack
  • Survivor backpack
  • Survivor runner pack
  • Travelpack
  • Dinosaur suit (now you can be a dinosaur while you dress as a dinosaur)
  • Wolf suit
  • Fencing jacket
  • Lamés in general
  • Leather apron
  • Arm warmers
  • Leg warmers
  • Solar backpacks
  • Foodperson mask (same vein as fursuits, it's statted out more like a giant foam mascot mask)
  • Migrated out XL leg warmers due to the above. For some wacky reason we never had an XL variant of arm warmers, weird.
  • Applied to the following mod items as well:
List:
  • Bag of holding (Aftershock)
  • Titanium vest (Aftershock)
  • Quantum solar backpacks (Aftershock)
  • Seven league boots (Magicylsm)
  • Boots of haste (Magiclysm)
  • Escape boots (Magiclysm)
  • Boots of grounding (Magiclysm)
  • Accordingly, migrated out XL variants of items in Aftershock that you can now just resize like normal.
  • Misc: gave VARSIZE to expensive flip-flops, bowling socks, white glove, glove liners, kabuto, being closely related to items that already have the flag.
  • Misc: gave OVERSIZE to leg magazine pouches, as leg ammo satchels were already oversize along with most "hangs from your belt" type items.
  • Misc: Gave OVERSIZE to noise canceling headgear, tinfoil hats, and 2-by-4 arm/leg guards, paper arm/leg guards, and bookplate being the mainly survivor-made and not really fitted so much as slapped together.
  • Misc: Added OVERSIZE to rain hood, bandana, rioter mask, makeshift flotation vest, blindfold, and towels, reasonably seeming like stuff that'd be easy to adjust.
  • Misc: Also added support for steel and superalloy clothing mods to survivor harness.
  • Misc: Gave OVERSIZE to all wearable instruments and stethoscopes.
  • Misc: Belatedly fixed XL swat armor in Aftershock lacking alloy padding option.
  • Misc: Merged the mostly redundant itemgroup file in Aftershock into the version already present in another folder dafuq

Describe alternatives you've considered

The following items were notably excluded but could be given compatibility if requested: rubber boots/gloves and the like (might presumably undermine the increased degree of watertightness assumed of them), MBR vests in general (the plates can only be so big and you're expanding them with just rags), kevlar vests (XL variant exists due to same thinking as with MBR vests), harder makeshift armors like chitin armor and all-plastic things (presumably would be harder to justify adjusting than more custom-fit stuff like plate armor?).

I also left long scarves untouched for now as if I recall Scarf has a WIP PR messing with them, plus they seem to be falvored as more than just for mutants given some can spawn in vanilla.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested a world with Aftershock added.
  3. Started as an uplifted enforcer. Boots, gloves, and belt correctly spawn in as XL.

image

Additional context

Checklist

@github-actions github-actions bot added data PRs related to datas. Won't crash game (probably) mods PR changes related to mods. labels Dec 28, 2023
Copy link
Contributor

autofix-ci bot commented Dec 28, 2023

The Autofix app has found code style violation and automatically formatted this Pull Request.

I locally edit my commits (e.g: git, github desktop)

Please choose following options:

I'd like to accept the automated commit
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

This PR is complete and I don't want to edit it anymore

It's safe to ignore this message.

I edit this PR through web UI

You can ignore this message and continue working.

I have no idea what this message is talking about

You can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005.

@github-actions github-actions bot added the tests PR changes related to tests label Dec 29, 2023
@scarf005 scarf005 merged commit a4914bb into cataclysmbnteam:main Dec 29, 2023
11 checks passed
@chaosvolt chaosvolt deleted the xl-mod-part-3-i-guess branch December 29, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably) mods PR changes related to mods. tests PR changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants