revert: "refactor: use std::clamp"
#4007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cee9587. due to `item::charges_per_volume` returning 0 when no charges fit in given volume, `std::clamp(10, 1, 0)` will return 0, which will always move entire stack of items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Describe the solution
due to
item::charges_per_volumereturning 0 when no charges fit in given volume,std::clamp(10, 1, 0)will return 0, which will always move entire stack of items.previous expression,
std::max(1, std::min(10, 0))will return 1 and work correctly hereDescribe alternatives you've considered
cri
Testing
was able to use plank to light up oven.
Additional context
urgent fix for 0.5.1