Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crashing when viewing armor item with undefined resitances #4303

Merged
merged 3 commits into from Mar 5, 2024

Conversation

LordZanos
Copy link
Contributor

Purpose of change

fix #4302

Items that are categorized as armor but don't have defined resistances will crash the game upon view.

Describe the solution

This was previously crash safe because we were using a null check, but the behavior was wrong. Added the null check back.

Describe alternatives you've considered

letting chaos scream and cry

Testing

Loaded up game, scrolled through entire debug spawner for items, no crash. Item resistance values look fine.

Additional context

Not a fix for INT_MIN physical resistance on some smaller items; I can't reproduce that issue on windows.

@github-actions github-actions bot added the src PR changes related to source code. label Mar 5, 2024
Copy link
Contributor

autofix-ci bot commented Mar 5, 2024

The Autofix app has found code style violation and automatically formatted this Pull Request.

I locally edit my commits (e.g: git, github desktop)

Please choose following options:

I'd like to accept the automated commit
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

This PR is complete and I don't want to edit it anymore

It's safe to ignore this message.

I edit this PR through web UI

You can ignore this message and continue working.

I have no idea what this message is talking about

You can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005.

chaosvolt
chaosvolt previously approved these changes Mar 5, 2024
@scarf005 scarf005 changed the title fix: fix crashing when viewing armor item with undefined resitances fix: crashing when viewing armor item with undefined resitances Mar 5, 2024
@scarf005 scarf005 merged commit 2b27074 into cataclysmbnteam:main Mar 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src PR changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash every time I open the Wear menu
3 participants