Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): Backalley ripper docs #4346

Merged
merged 13 commits into from Mar 15, 2024

Conversation

Zlorthishen
Copy link
Contributor

@Zlorthishen Zlorthishen commented Mar 14, 2024

Purpose of change

adds three new back alley ripper doc locations

Describe the solution

Describe alternatives you've considered

Testing

created a new world, verified that new maps spawn in correctly

Additional context

  • urban_19_victorian.json
    image
  • urban_26_dense_club.json
    image
  • urban_28_dense_cafe_laundry.json
    image

Checklist

@github-actions github-actions bot added the data PRs related to datas. Won't crash game (probably) label Mar 14, 2024
Copy link
Contributor

autofix-ci bot commented Mar 14, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@Zlorthishen
Copy link
Contributor Author

on a related note, some of the dense urban areas rarely spawn

@Zlorthishen Zlorthishen marked this pull request as ready for review March 14, 2024 01:16
@scarf005 scarf005 requested a review from chaosvolt March 14, 2024 02:22
moved some machinery to block the door better
@ekaratzas
Copy link
Contributor

What's the proper way to test something like this change? Let's say you spawn a new character in a new world and you wanna test out specific locations.

@scarf005
Copy link
Member

scarf005 commented Mar 14, 2024

What's the proper way to test something like this change? Let's say you spawn a new character in a new world and you wanna test out specific locations.

you can use debug overmap editor.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:3

@scarf005 scarf005 merged commit 43061bf into cataclysmbnteam:main Mar 15, 2024
10 checks passed
@Zlorthishen Zlorthishen deleted the backalley_ripper_docs branch March 15, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants