Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): farming zone activity warns if it is too cold #4347

Merged
merged 1 commit into from Mar 14, 2024
Merged

fix(UI): farming zone activity warns if it is too cold #4347

merged 1 commit into from Mar 14, 2024

Conversation

ekaratzas
Copy link
Contributor

@ekaratzas ekaratzas commented Mar 14, 2024 •
edited by scarf005

Purpose of change

Warn players if it's too cold to plant seeds via farming zone activity.

Describe the solution

Return unique error code if it's too cold to plant a seed and display meaningful error message in this corner-case.

Describe alternatives you've considered

Does not seem to be fixed in cdda after casually perusing their codebase so nothing to port.

Testing

in spring.

  • character has seeds and shovel.
  • create farming zone.
  • try to farm via zone activity.
  • character churns the earth.
  • character fails to plant seeds.
  • appropriate error message is displayed.

too_cold_farm

Additional context

Checklist

@github-actions github-actions bot added the src PR changes related to source code. label Mar 14, 2024
@scarf005 scarf005 changed the title fix: farming zone activity warns if it is too cold fix(UI): farming zone activity warns if it is too cold Mar 14, 2024
scarf005
scarf005 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@scarf005 scarf005 merged commit e6bcde7 into cataclysmbnteam:main Mar 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarf005 scarf005 scarf005 approved these changes

Assignees
No one assigned
Labels
src PR changes related to source code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zone Activities for farming does not report it's too cold
2 participants
@ekaratzas @scarf005