-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sausage casings can be made with plastic and spawngroups #4520
Conversation
I hate my phone for doing automatic capital letters. |
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
@chaosvolt or @scarf005 . I can't tell why it is failing on me this time. Can you check? |
¯\(ツ)/¯ |
@Coolthulhu or @olanti-p is there a quick fix for it? |
Seems to work now. No changes planned anymore. Testing worked fine. |
Don't think using bag plastic for sausage casings is a great idea. My suggestion if this is to allow artificial casings would be to use some collagen based stuff as we do irl. An example recipe can be seen in our discord discussions here. |
I can't connect to discord for the next 2 weeks. But the problem is follows, there are plastic made sausage castings. You can check wish and other sides. So yes, those exists. The main function of them is to keep the sausage "meat" inside a "container". How should the collagen stuff work anyway? And this result at least give us the chance to make it without stomachs. It also took a lot of work me to create. So I would be more comfortable if it gets in the game, and if someone has a better idea in solving the recipe, can do it afterwards or directly here. |
It exists, so I created it. A collagen version can be added later. |
@chaosvolt so since you seem to be online here. Is there anything against the addition? I would be happy for a merge. |
What is still missing here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't need the collagen version to be a completely separate item to be honest, it could instead be an alternative way to make the normal sausage casings instead. Which I figure it's fine to save for a followup PR if need be.
I'm also not really sure if the plastic version really needs to be a separate item either for that matter? Aside from, what, the need to add a plastic mold to the recipe? Also I was busy basically most of yesterday and got distracted once I finally got home. :V
All good. The reason for it being a separate item is: the material. Plastic version is made of plastic, the other one of flesh. We don't have veggy sausages yet, but if they get into the game, we need a non flesh alternative for vegetarians. That was the reason to make a separate item. True the plastic mold is not necessary. I remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair I suppose, material is a tricky thing. I guess main reason it isn't super important is that the end product can't really vary based off input material anyway, and even if it could we don't currently have veggy sausages so it doesn't yet have any gameplay effect whether you use real casings or sausage casings.
Doesn't really mandate insisting the file changes be reverted or anything since it's just a flavor thing all around, so ¯\(ツ)/¯
I will probably work on a veggy sausages recipe, probably when I get home and get reminded. |
Mmmhmmmmm microplastics in BN, yummy! |
Only the best plastic! |
Purpose of change
Since my change suggestions weren't implemented, I did it myself on my old phone again.
Describe the solution
Describe alternatives you've considered
Testing
Additional context
Still pain on my phone.
Checklist