Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): lightweight superalloy survivor suit #4553

Merged
merged 4 commits into from May 9, 2024

Conversation

yay855
Copy link
Contributor

@yay855 yay855 commented Apr 29, 2024

Purpose of change

The light survivor suit is decent for what it is, but a superalloy variant would make sense, given there's one of the heavy version.

Describe the solution

Added lightweight superalloy survivor suit, an electrically conductive but more protective version of the lightweight survivor suit.

Describe alternatives you've considered

Testing

Additional context

Checklist

The survivor suits are now stronger, as they should be given their kevlar compositions. Reduced warmth of the light survivor suit, since it's lighter than the regular one. Added in light superalloy survivor suit, as a halfway point between the light survivor suit and the medium/heavy ones.
@github-actions github-actions bot added the data PRs related to datas. Won't crash game (probably) label Apr 29, 2024
Copy link
Contributor

autofix-ci bot commented Apr 29, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@VissValdyr
Copy link
Contributor

Survivor suits offered other bonuses:

  1. plate armor is not auto learn, books are needed
  2. They offer storage
  3. Plate armor has no 100% coverage. Only 95%. So it will let some damage through, suits offer 100%.
  4. Plate armor conducts electricity.

@yay855
Copy link
Contributor Author

yay855 commented Apr 29, 2024

That's all true- and you're right that, when looking at it like that, survivor suits aren't so bad. They're more akin to plated leather armor using more modern materials. The problem is that there's no kevlar equivalent to plate armor that isn't much, much more encumbering or is uncraftable. Still, you're right, I think I'll reduce if not revert the changes to the survivor suits, though I still want to keep the light superalloy one. Especially since I forgot to give it a crafting recipe...

@Zireael07
Copy link
Contributor

They're more akin to plated leather armor using more modern materials.

That's exactly what they're meant to be.

The problem is that there's no kevlar equivalent to plate armor that isn't much, much more encumbering or is uncraftable.

Kevlar isn't meant to be a magic solve-all solution

@yay855
Copy link
Contributor Author

yay855 commented Apr 29, 2024

I mean. Yeah, you're right. I'll revert the changes to thickness, though I still want the superalloy light survivor suit; it's a nice compromise, especially since it using superalloy means it channels electricity. And I still want to review the armor relative to plated leather armor, see how they measure up.

Edit: yeah, no, the standard survivor suit lines up with the plated leather armor nicely. Alright, I feel silly now. Still, the superalloy lightweight survivor suit is a nice addition.

@yay855 yay855 changed the title feat(content): Survivor suits feat(content): lightweight superalloy survivor suit Apr 29, 2024
@yay855 yay855 marked this pull request as draft April 29, 2024 07:38
@yay855 yay855 marked this pull request as ready for review April 29, 2024 07:41
@yay855 yay855 marked this pull request as draft April 29, 2024 07:49
@yay855 yay855 marked this pull request as ready for review April 29, 2024 07:51
@chaosvolt chaosvolt merged commit e72ace0 into cataclysmbnteam:main May 9, 2024
10 checks passed
@yay855 yay855 deleted the survivor-suit-rebalance branch May 9, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants