Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patchwork skin correctly develops from fur or scales #4572

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented May 1, 2024

Purpose of change

This tackles chimera mutants waffling weirdly between fur and scales by making the patchwork skin mutation actually evolve from either of the relevant mutations.

Fixes #4567

Describe the solution

  1. Set both LIGHTFUR and SCALES mutations to have PATCHSKIN1 as a valid changes_to, so either mutation can evolve into it if given the chance.
  2. Changed PATCHSKIN1 to have LIGHTFUR and SCALES for prereqs instead of SKIN_ROUGH, which should create a one-way relationship for the mutations.

Describe alternatives you've considered

  1. Setting valid to false for Patchwork Skin so that generic mutagen can't risk triggering a potential one-way relationship. This would mean that aspiring chimeras chugging generic mutagen would still witness the eternal fur-vs-scale dance.
  2. Simply removing fur and scales from chimera category outright.
  3. Bullying the issue OP into PRing this fix themselves like Viss wanted.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Load-tested and chugged an assload of chimera mutagen.
  3. Observed Rough Skin developing into Lightly Furred, then later on into Patchwork Skin instead of committing waffle crimes.

image

Additional context

Checklist

@github-actions github-actions bot added the data PRs related to datas. Won't crash game (probably) label May 1, 2024
@chaosvolt
Copy link
Member Author

Been in approval for 3 days so :3

@chaosvolt chaosvolt merged commit 6f048f0 into cataclysmbnteam:main May 8, 2024
10 checks passed
@chaosvolt chaosvolt deleted the chimeras-are-furries-and-so-are-catgirls branch May 8, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove LIGHTFUR and SCALES mutation from the CHIMERA.
2 participants