Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't give holdout npc missions to starter npcs #4587

Merged
merged 1 commit into from May 9, 2024
Merged

fix: don't give holdout npc missions to starter npcs #4587

merged 1 commit into from May 9, 2024

Conversation

chaosvolt
Copy link
Member

Purpose of change

This fixes the new missions added by Zlor's NPC ports recently inexplicably showing up on starter NPCs.

Fixes #4583

Describe the solution

  1. Set the homeless camp NPC missions from ORIGIN_OPENER_NPC to ORIGIN_SECONDARY.
  2. Set the chemist NPC missions from ORIGIN_OPENER_NPC to ORIGIN_SECONDARY.
  3. Set the scrap trader NPC missions from ORIGIN_OPENER_NPC to ORIGIN_SECONDARY.

Describe alternatives you've considered

screm

Testing

Used my eyes.

Additional context

Checklist

@github-actions github-actions bot added the data PRs related to datas. Won't crash game (probably) label May 5, 2024
@chaosvolt chaosvolt enabled auto-merge (squash) May 9, 2024 17:06
@Zlorthishen
Copy link
Contributor

my bad, i should have caught that

@chaosvolt chaosvolt merged commit 323886b into cataclysmbnteam:main May 9, 2024
10 checks passed
@chaosvolt chaosvolt deleted the new-npc-quest-fixes branch May 9, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarf005 scarf005 scarf005 approved these changes

Assignees
No one assigned
Labels
data PRs related to datas. Won't crash game (probably)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Odd quests given by starting NPCs
3 participants
@chaosvolt @Zlorthishen @scarf005