fix: Specific guns now have correct copy-from
to fix their weapon categories.
#4604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
A long time ago someone on the discord noted that several guns have the wrong categories applied, I checked and agreed, and changed the copy-from so that they now point at the right category.
Describe the solution
Change
copy-from
for the following guns.pistol_base
->pistol_1shot
rifle_manual
->rifle_semi
shotgun_base
->shotgun_1shot
shotgun_base
->shotgun_pump
Describe alternatives you've considered
Leaving it alone until someone points it out again.
Testing
Load up the game, check that:
Additional context
I made derringers count as 1 shot guns due to their barrel arrangement, we could probably make them into another abstract that uses manual action to separate them from true 1shot guns that lack any kind of rotating firing pin or similar mechanism.
Checklist