Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Specific guns now have correct copy-from to fix their weapon categories. #4604

Merged
merged 1 commit into from May 8, 2024

Conversation

KheirFerrum
Copy link
Collaborator

@KheirFerrum KheirFerrum commented May 8, 2024

Purpose of change

A long time ago someone on the discord noted that several guns have the wrong categories applied, I checked and agreed, and changed the copy-from so that they now point at the right category.

Describe the solution

Change copy-from for the following guns.

  • Mossberg Brownie: pistol_base -> pistol_1shot
  • SKS: rifle_manual -> rifle_semi
  • Pipe Shotgun: shotgun_base -> shotgun_1shot
  • M1897 Trench Gun: shotgun_base -> shotgun_pump

Describe alternatives you've considered

Leaving it alone until someone points it out again.

Testing

Load up the game, check that:

  • Mossberg Brownie is now in One Shot category
  • SKS is now in Autoloading category
  • Pipe Shotgun is now in One Shot category.
  • M1897 Trench Gun is now in Manual Action category

Additional context

I made derringers count as 1 shot guns due to their barrel arrangement, we could probably make them into another abstract that uses manual action to separate them from true 1shot guns that lack any kind of rotating firing pin or similar mechanism.

Checklist

@github-actions github-actions bot added the data PRs related to datas. Won't crash game (probably) label May 8, 2024
@chaosvolt chaosvolt merged commit 70d9094 into cataclysmbnteam:main May 8, 2024
10 checks passed
@KheirFerrum KheirFerrum deleted the Fix-copy-froms branch May 8, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants