-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content): weather reports from radio, new flag WEATHER_FORECAST #4650
Conversation
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
Sometimes radio fails to get weather information. In this way it does not produce any sensible messages. Could you add something like: "No signal from broadcasting tower" or "Broadcasting weather signal was not found"? It can be added later if check like that is hard to implement. |
I am totally honest with you, that would totally impossible for me to do. This alone was hard (I never learned C++, all that stuff is just reverse engeneering) |
No worries. Can be done later in other PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready.
Upd: Not yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopin' we gud
Purpose of change
There was a weather report, which was... a bit on the bad side. It worked, but didn't look good. To get it, you needed a radio and the right broadcasting tower, which was a chore. Now you can activate your radio and directly read out the weather report of the nearest broadcasting tower.
It uses a new flag "FORECAST_WEATHER" and can be used with the use_action "WEATHER_TOOL". Right now, only the radio has the possibility. It can be further expanded, if needed (for example, most MP3 players have a inbuilt FM/AM Radio)
Describe the solution
Describe alternatives you've considered
Testing
Took some time and @chaosvolt helped a lot!
Additional context
Checklist