Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): weather reports from radio, new flag WEATHER_FORECAST #4650

Merged
merged 6 commits into from
May 14, 2024

Conversation

Lamandus
Copy link
Contributor

Purpose of change

There was a weather report, which was... a bit on the bad side. It worked, but didn't look good. To get it, you needed a radio and the right broadcasting tower, which was a chore. Now you can activate your radio and directly read out the weather report of the nearest broadcasting tower.

It uses a new flag "FORECAST_WEATHER" and can be used with the use_action "WEATHER_TOOL". Right now, only the radio has the possibility. It can be further expanded, if needed (for example, most MP3 players have a inbuilt FM/AM Radio)

Describe the solution

Describe alternatives you've considered

Testing

Took some time and @chaosvolt helped a lot!

Additional context

grafik
grafik

Checklist

@github-actions github-actions bot added src PR changes related to source code. data PRs related to datas. Won't crash game (probably) labels May 13, 2024
@Lamandus Lamandus changed the title Smarterwatch feat(content): weather reports from radio, new flag WEATHER_FORECAST May 13, 2024
Copy link
Contributor

autofix-ci bot commented May 13, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@Firestorm01X2
Copy link
Collaborator

Firestorm01X2 commented May 13, 2024

Sometimes radio fails to get weather information. In this way it does not produce any sensible messages. Could you add something like: "No signal from broadcasting tower" or "Broadcasting weather signal was not found"?

It can be added later if check like that is hard to implement.

@Lamandus
Copy link
Contributor Author

Sometimes radio fails to get weather information. In this way it does not produce any sensible messages. Could you add something like: "No signal from broadcasting tower" or "Broadcasting weather signal was not found"?

It can be added later if check like that is hard to implement.

I am totally honest with you, that would totally impossible for me to do. This alone was hard (I never learned C++, all that stuff is just reverse engeneering)

@Firestorm01X2
Copy link
Collaborator

I am totally honest with you, that would totally impossible for me to do. This alone was hard (I never learned C++, all that stuff is just reverse engeneering)

No worries. Can be done later in other PRs.

Firestorm01X2
Firestorm01X2 previously approved these changes May 13, 2024
Copy link
Collaborator

@Firestorm01X2 Firestorm01X2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready.
Upd: Not yet.

src/iuse.cpp Outdated Show resolved Hide resolved
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopin' we gud

@chaosvolt chaosvolt merged commit f792563 into cataclysmbnteam:main May 14, 2024
13 checks passed
@Lamandus Lamandus deleted the smarterwatch branch May 15, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably) src PR changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants