Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): new gun ASR Aero Survival Rifle 10mm edition #4832

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

Lamandus
Copy link
Contributor

@Lamandus Lamandus commented Jun 19, 2024

Checklist

Required

Purpose of change

To add more options for 10 mm guns, I found the ASR Aero Survival Rifle as a fitting option. It uses glock 20 magazines and can be compared to the cx4 Storm (9mm rifle). Low droprate, but still managable to be found in the wild.

Describe the solution

  1. Add new item ASR_10mm
  2. add nested and everyday version
  3. add itemgroups into droplists.
  4. add to generic gun merging list.

Describe alternatives you've considered

Add different caliber versions of the same gun. But that would be somewhat lazy, maybe I find good rifle options for other offered calibers. If not, I can still add the other ASR in another PR.

Testing

grafik

Additional context

Please check the values I used. I have no "feeling" for them and I was guessing it by checking other guns.

https://www.tnwfirearms.com/product-p/asrx-cplt-xxxx-xxxx-xxxx.htm

@github-actions github-actions bot added data PRs related to datas. Won't crash game (probably) mods PR changes related to mods. labels Jun 19, 2024
Copy link
Contributor

autofix-ci bot commented Jun 19, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@chaosvolt chaosvolt merged commit 0e34548 into cataclysmbnteam:main Jun 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably) mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants